Conversation
dennwc
force-pushed
the
sip_dtmf
branch
2 times, most recently
from
March 7, 2024 19:16
da7f07d to
b70845f
Compare
Contributor
Author
|
Hmm, right, the integration test needs an updated |
dennwc
marked this pull request as ready for review
March 8, 2024 17:24
Contributor
Author
|
Removed test for SIP messages. It will be tested in SIP repo anyway. Ready for final review now. |
biglittlebigben
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept and send DTMF via data channel. Also take the chance to make data callbacks and functions accept an interface for data messages.
Blocked on livekit/protocol#630