Revert default behavior change with data publishing - #421
Merged
Conversation
boks1971
approved these changes
Mar 12, 2024
Contributor
|
I think the expectation about using server SDK is that it abstracts away the packet drop and just delivers app-specific data reliably by default. I think setting it as unreliable is a kind of optimization that app developers may consider (later?). This is why I changed it this way. Also note that in our own protobuf the default is also So I'm wondering why you'd like the default to be |
Contributor
|
From Slack:
|
dennwc
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.