-
Notifications
You must be signed in to change notification settings - Fork 31
runner: Improve live video-to-video runner stability #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd13ec0 to
57f34a2
Compare
Member
Author
|
Status: Made sure the basic workflow runs successfully. Pending to test some failure scenarios to ensure things are good (and better than before) |
8eeeb1e to
9027415
Compare
This reverts commit 9027415.
j0sh
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Runner lifecycle
The high level description of the new behavior is:
/healthendpoint periodically (5s)OKinfer.pyprocess (if it's running)IDLEif no process is runningERRORif it's running but state isOFFLINE, orOKotherwiseNotice that the
infer.pyprocess will automatically kill itself when the input stream stops, so that means we can now reuse containers! After input stream ends or input frames stop for 60s, theinfer.pyprocess will kill itself which means the runner API will start returningIDLEand then the worker will eventually put it back in the pool for other requests.