live/streamer: Fix streamer shutdown logic #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working on #371 I realized how messy the lifecycle management of the streamer was.
This is to simplify and improve that a bunch.
Issues
Previously, we started a bunch of loose background tasks and had no central way of controlling them.
There were mainly 2 issues:
Fixes
So this improved this 2 issues in 2 steps:
This will also make sure that we don't keep the streamer running when any of the tasks fail. This happened for the monitor loop on a recent version and no one ever realized, cause it only got logged but didn't crash the whole thing.