Skip to content

fix(embeds): resolve relative image paths in MarkdownEmbed #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeveloperAlly merged 2 commits into from
Apr 8, 2026
+28 −2
Merged

fix(embeds): resolve relative image paths in MarkdownEmbed #871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c2a79
Initial plan
Copilot Apr 8, 2026
f2b5376
fix(embeds): resolve relative image paths in MarkdownEmbed component
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions snippets/components/integrators/embeds/DataEmbed.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,22 @@ export const MarkdownEmbed = ({ url, className = '', style = {}, ...rest }) => {
const [html, setHtml] = useState('')

useEffect(() => {
// Derive base URL so relative image paths in the remote file can be resolved
const lastSlash = url.lastIndexOf('/')
const baseUrl = lastSlash >= 0 ? url.substring(0, lastSlash + 1) : ''
const origin = baseUrl.match(/^(https?:\/\/[^/]+)/)?.[1] ?? ''

const resolveUrl = (src) => {
// Pass through absolute URLs, protocol-relative, data URIs, and fragment links
if (/^https?:\/\//i.test(src) || src.startsWith('//') || src.startsWith('data:') || src.startsWith('#')) return src
// Root-relative paths anchor to the origin, not the directory base
if (src.startsWith('/')) return origin + src
return baseUrl + src
}

const escapeAttr = (str) =>
String(str).replace(/&/g, '&amp;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;')

fetch(url)
.then((res) => res.text())
.then((md) => {
Expand All @@ -102,10 +118,20 @@ export const MarkdownEmbed = ({ url, className = '', style = {}, ...rest }) => {
.replace(/```(\w*)\n([\s\S]*?)```/g, '<pre><code>$2</code></pre>')
// Inline code
.replace(/`([^`]+)`/g, '<code>$1</code>')
// Images
// Markdown images — resolve relative src to absolute
.replace(
/!\[([^\]]*)\]\(([^)]+)\)/g,
'<img alt="$1" src="$2" style="max-width:100%" />'
(_, alt, src) => `<img alt="${escapeAttr(alt)}" src="${escapeAttr(resolveUrl(src))}" style="max-width:100%" />`
)
// Raw HTML img tags with double-quoted src — resolve relative src to absolute
.replace(
/<img\b([^>]*)src="([^"]*)"([^>]*)>/gi,
(_, before, src, after) => `<img${before}src="${resolveUrl(src)}"${after}>`
)
// Raw HTML img tags with single-quoted src — resolve relative src to absolute
.replace(
/<img\b([^>]*)src='([^']*)'([^>]*)>/gi,
(_, before, src, after) => `<img${before}src="${resolveUrl(src)}"${after}>`
)
// Links
.replace(
Expand Down
Loading