Skip to content

chore(deps): clear the fixable dependabot vulnerability alerts - #788

Merged
rickstaa merged 1 commit into
mainfrom
chore/dependency-refresh
Sep 7, 2026
Merged

chore(deps): clear the fixable dependabot vulnerability alerts#788
rickstaa merged 1 commit into
mainfrom
chore/dependency-refresh

Conversation

@rickstaa

@rickstaa rickstaa commented Sep 7, 2026

Copy link
Copy Markdown
Member

Clears the bulk of the open Dependabot alerts (local pnpm audit: 144 findings → 21).

  • pnpm update: re-resolves every transitive within its declared range (axios, hono, js-yaml, brace-expansion, and ~80 more alerts).
  • pnpm.overrides: axios ^1.18.0, postcss ^8.5.23 (next pins 8.4.31 exactly), ws@^8 → ^8.21.3 — patched versions their parents don't reach yet.
  • Removes apollo-fetch: unused since fix: change create a poll LIP fetch to cached runtime API call #712 moved the LIP fetch to a runtime API route; it pinned the vulnerable node-fetch 1.x.
  • @types/node → 24, matching the runtime.

What remains and why: a dev-only cluster under @graphql-codegen v2 and @lhci/cli (cleared by their major bumps, separate PR), elliptic/extract-zip (no patch exists — to be dismissed on GitHub), and sharp/uuid/decode-uri-component/cookie (need a next bump or risky major overrides — deferred).

Verified under Node 24: lint, typecheck, 363/363 tests, production build, and /api/ens-data returning 200 on the built server.

pnpm update refreshes every in-range transitive. Overrides force
axios, postcss, and ws past advisories their parents still pin
below, and apollo-fetch (unused since the LIP fetch moved to a
runtime API route) leaves with its vulnerable node-fetch 1.x.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 7, 2026 08:42
@rickstaa
rickstaa requested a review from ECWireless as a code owner September 7, 2026 08:42
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
explorer-arbitrum-one Ready Ready Preview Sep 7, 2026 8:43am UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It performs a large, wide-ranging dependency re-resolution and introduces security-motivated overrides, which warrants final human review despite no concrete issues found in the manifest change itself.

Pull request overview

This PR focuses on reducing the repository’s Dependabot/pnpm audit vulnerability surface by updating dependency versions within allowed ranges, removing an unused vulnerable package, and applying targeted pnpm.overrides to force patched transitive versions that aren’t otherwise reachable.

Changes:

  • Updated a broad set of direct dependencies/devDependencies to newer patch/minor versions (and some larger within-major updates) to pick up security fixes.
  • Removed apollo-fetch from dependencies (per PR description: unused since the runtime API route change).
  • Added pnpm.overrides entries for axios, postcss, and ws@^8.0.0, and bumped @types/node to align with Node 24.
File summaries
File Description
package.json Dependency and devDependency version updates; removal of apollo-fetch; adds pnpm.overrides for patched transitive versions; aligns @types/node with Node 24 runtime.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@rickstaa
rickstaa merged commit 4fa7a23 into main Sep 7, 2026
9 checks passed
@rickstaa
rickstaa deleted the chore/dependency-refresh branch September 7, 2026 08:53
rickstaa added a commit that referenced this pull request Sep 7, 2026
2.17.7 pulls the ESM-only htmlparser2 12, which crashes Vercel's
function runtime at import and 500s every /api/ens-data call. The
exact pin stops in-range refreshes from re-landing it (as #788's
pnpm update silently did) until the runtime is confirmed >=20.19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants