docs(pricing): update delivery summary to verified merged + prod-deployed state#432
Merged
Merged
Conversation
…ed state Section 1 now reflects live gh + Vercel/GitHub-deployment reality: - naap #430 (signer composite-bearer fix + perf-mode skill): MERGED 99b3d39, prod deploy dpl_HLWWTS3ivsGa5NAMp9qa8J1jj83u READY (operator.livepeer.org). - storyboard #685 (seedance reroute): prod deploy 5530586270 success (confirmed, previously "pending redeploy"). - storyboard #687 (unit_kind/quantity_source): MERGED fc78484, prod success. - storyboard #688 (registry parity): MERGED bda8eef (main HEAD), prod success. - Added simple-infra #106 billing-fix row: still OPEN issue, infra-owned, not deployed (no closing PR). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated the pricing delivery summary to document Section-1 components as merged and production deployed, retain the billing fix as an undeployed open issue, and refresh verification and footer details. ChangesPricing delivery status
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@PRICING-DELIVERY-SUMMARY.html`:
- Around line 107-111: Update the Section 2 wording near the `#685` reroute
reference so it no longer claims the reroute stops billing aborted jobs. Clarify
that `#685` only mitigates or reduces exposure to the failing route, while the
billing correction in simple-infra `#106` remains undeployed.
- Line 61: The Section-1 production claim in the summary must distinguish
deployed production code from agent configuration. Revise the sentence around
“entire Section-1 foundation” to state that the production-code components are
merged and deployed, while the storyboard-perf-mode skill files are merged/on
main but not included in the deployed web bundle.
- Around line 75-76: Update the checks summary in the merged deployment entry to
reconcile the red-check count: either describe Audit and Quality Gates as two
red checks, or explicitly state that both represent one underlying
dependency-advisory failure. Ensure the count and explanation consistently match
the listed check names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8533a7fa-69ba-48f4-94fe-2096c29bef62
📒 Files selected for processing (1)
PRICING-DELIVERY-SUMMARY.html
| <div class="bottomline"> | ||
| <b>Bottom line — is pricing solved yet?</b> | ||
| Not end-to-end, but the foundation is in and the full plan is approved. The Storyboard-side descriptor work (the lossless <code>unit_kind</code> + <code>quantity_source</code> source of truth) and the perf/reliability fix are done, and the complete upstream execution plan is written and agreed. True per-unit billing — where the agent's USD quote equals the on-chain settled fee equals the pymthouse metered amount — still depends on the upstream owners' PRs (Josh in go-livepeer, Rick in python-gateway, John in pymthouse) plus the two simple-infra infra gates. So: <b>Storyboard foundation shipped + plan locked; end-to-end per-unit billing pending upstream.</b> | ||
| Not end-to-end, but the entire Section-1 foundation is now <b>merged to <code>main</code> and live in PRODUCTION</b>, and the full upstream plan is approved. The Storyboard-side descriptor work (the lossless <code>unit_kind</code> + <code>quantity_source</code> source of truth, #687 + #688), the perf/reliability re-route (#685), and the billed-path signer auth fix (#430) all shipped and prod-deployed (Vercel READY/success — evidence below). True per-unit billing — where the agent's USD quote equals the on-chain settled fee equals the pymthouse metered amount — still depends on the upstream owners' PRs (Josh in go-livepeer, Rick in python-gateway, John in pymthouse) plus the two simple-infra infra gates (#106, #107). So: <b>Storyboard + signer foundation shipped & deployed; end-to-end per-unit billing pending upstream.</b> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Narrow the “entire Section-1 foundation” production claim.
This can be read as saying every Section-1 row is production-deployed, but the storyboard-perf-mode row explicitly says its skill files are agent configuration and are not part of the deployed web bundle. State that the production-code components are deployed, while the skill is merged/on main.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PRICING-DELIVERY-SUMMARY.html` at line 61, The Section-1 production claim in
the summary must distinguish deployed production code from agent configuration.
Revise the sentence around “entire Section-1 foundation” to state that the
production-code components are merged and deployed, while the
storyboard-perf-mode skill files are merged/on main but not included in the
deployed web bundle.
Comment on lines
+75
to
+76
| <td><span class="pill merged">MERGED</span> <span class="pill merged">PROD DEPLOYED</span></td> | ||
| <td><b>Self-reviewed ✓</b> — code delta is a pure dead-code removal (deletes the orphaned <code>mintUserSignerJwtForExternalUser()</code> + <code>UserSignerJwt</code>, zero non-test call sites, superseded by #421/#412/#424) + a docstring correction on <code>resolveSignerEndpoint()</code>; the composite-bearer / api-key-exchange billed path is unchanged (no-regression). <b>Checks ✓ (with 1 unrelated red)</b> — Lint&TypeCheck, Build, Shell tests all PASS; the only red checks were <code>Audit</code> + its <code>Quality Gates</code> rollup, a date-based dependency-CVE advisory failure (node-tar/undici/ws/uuid/ethers) that fires on every PR today and is unrelated (this PR touches NO <code>package.json</code>/lockfile). Admin-merged over that unrelated red. <b>Merged ✓</b> gh: <code>MERGED 2026-07-21</code> → <code>main</code>, squash commit <code>99b3d39</code>. <b>Prod-deployed ✓</b> Vercel <code>naap-platform</code> deploy <code>dpl_HLWWTS3ivsGa5NAMp9qa8J1jj83u</code> = <b>READY</b> (target production, ref <code>main</code>, sha <code>99b3d39</code>, aliased to <code>operator.livepeer.org</code>).</td> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Reconcile the failed-check count.
The evidence says “1 unrelated red” but then identifies both Audit and its Quality Gates rollup as red. Clarify whether this is one underlying advisory failure surfaced by two checks, or report two red checks.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PRICING-DELIVERY-SUMMARY.html` around lines 75 - 76, Update the checks
summary in the merged deployment entry to reconcile the red-check count: either
describe Audit and Quality Gates as two red checks, or explicitly state that
both represent one underlying dependency-advisory failure. Ensure the count and
explanation consistently match the listed check names.
Comment on lines
+107
to
+111
| <td><b>Billing fix — stop billing aborted jobs</b><br><span class="note">SDK <code>/inference</code> per-model SLA timeout tiering + async hand-off; STOP billing aborted/failed jobs</span></td> | ||
| <td>livepeer/simple-infra</td> | ||
| <td><a href="https://github.com/livepeer/simple-infra/issues/106">#106</a></td> | ||
| <td><span class="pill open">OPEN ISSUE</span> <span class="pill pending">NOT DEPLOYED</span></td> | ||
| <td><b>Not ours to merge — infra-owned, still pending.</b> gh: <code>#106</code> is an <code>ISSUE</code> (not a PR), <code>state OPEN</code>, <code>closedAt null</code>, no assignee. No PR closes it — the only cross-references are simple-infra #107 (warm-orch, OPEN), storyboard #686 (tracking, OPEN) and storyboard #685 (the temp reroute, CLOSED). So the billing fix (stop metering aborted/failed jobs + SLA timeout tiering) is <b>NOT merged and NOT in production</b>; it is an infra-team item (John / simple-infra per the upstream scope doc). The #685 reroute mitigates the symptom in prod, but the root-cause billing gate remains open.</td> |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Remove the contradictory billing claim in Section 2.
This row correctly says simple-infra #106 is not deployed, but line 135 still says the #685 reroute “stops billing aborted jobs.” #685 mitigates the failing route; it does not implement the billing fix. Change that wording to distinguish reduced exposure from the undeployed billing correction.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PRICING-DELIVERY-SUMMARY.html` around lines 107 - 111, Update the Section 2
wording near the `#685` reroute reference so it no longer claims the reroute stops
billing aborted jobs. Clarify that `#685` only mitigates or reduces exposure to
the failing route, while the billing correction in simple-infra `#106` remains
undeployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Section-1 landing work. Updates
PRICING-DELIVERY-SUMMARY.htmlso every Section-1 item shows its verified status (self-reviewed / checks-green / merged-to-main / prod-deployed) with evidence, instead of the pre-merge "OPEN PR" snapshot.storyboard-perf-modeskill): MERGED99b3d39→ prod deploydpl_HLWWTS3ivsGa5NAMp9qa8J1jj83uREADY (aliased tooperator.livepeer.org). Admin-merged over an unrelated date-based dependency-CVEAuditred (nopackage.json/lockfile touched; TypeCheck/Build/Shell green).5530586270success — confirms the prefer_fast reroute is live (was "pending redeploy").unit_kind/quantity_source): MERGEDfc78484, prod success.bda8eef(currentmainHEAD), prod success.Evidence sourced from live
ghPR/issue state, the Vercel MCP (get_deployment), and GitHub deployment records.Test plan
<tr>/</tr>balanced (25/25)PRICING-DELIVERY-SUMMARY.htmlchangedMade with Cursor
Summary by CodeRabbit