Fix flag URLs when the application is served from a subdirectory - #2794
Merged
Conversation
ghabriel25
marked this pull request as ready for review
September 2, 2026 02:36
ghabriel25
marked this pull request as draft
September 2, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AssetManager::flagUrl()(used by the<flux:flag>component) generated a root-relative path via:When the Laravel app lives under a path prefix / subdirectory, the browser resolves
/flux/flags/XXagainst the domain root instead of the application base. This results in 404s for flag SVGs.Reported in #2793.
Related PR: #2183
Solution
Wrap the relative route result with Laravel’s
url()helper so the generated URL respects the application’s base path/ APP_URL /:Fixes: #2793