[4.x] Prefer new Collection() over collect() helper - #10505
Open
ghabriel25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a pure refactor that replaces calls to Laravel’s global
collect()helper with direct instantiation ofnew Collection(...)throughout the Livewire 4.x codebase.It aligns Livewire with a convention adopted in the Laravel framework itself, which prefers
new Collection()for:The change has no intended behavioral impact. All existing Collection method chaining, filtering, mapping, etc. continue to work exactly as before.
Motivation
The
collect()helper is a thin convenience wrapper without any logic in it. Calling the helper adds an unnecessary extra stack frame and a global function lookup.Laravel core has begun preferring the explicit constructor in its own source for the reasons listed above. This PR brings Livewire in line with that style.