feat(ci): enrich Discord release notifications - #528
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe Discord notification script now collects and formats bounded release notes, pull requests, linked issues, and preview summaries. Release, nightly, reconciliation, and first-preview workflow steps pass the required metadata and credentials. Release-readiness processing exports nightly lists through multiline GitHub Actions outputs. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 243-249: The release notification flow uses the wrong commit when
resolving release changes. In .github/workflows/release.yml lines 243-249, add
HEAD_SHA to the Notify Discord releases channel step environment using the
commit associated with needs.compute-release.outputs.tag; in
scripts/notify-discord.sh lines 230-236, replace the empty-HEAD_SHA fallback to
GITHUB_SHA with gh api against release_tag and use the returned .sha value.
In `@scripts/notify-discord.sh`:
- Around line 222-229: Replace the head-based truncation in
scripts/notify-discord.sh lines 222-229 with a sed expression that limits output
to 20 lines without closing an upstream pipe. In scripts/notify-discord.sh lines
167-187, replace the head-based 8-line limit with sed-based termination and
replace the printf-to-grep summary check with a Bash pattern match; update both
sites to avoid early-exit pipelines under pipefail.
- Around line 326-335: Update the Discord webhook request around the http_code
capture to create a unique response-file path with mktemp instead of the fixed
/tmp path, and pass that path to curl and the subsequent cat. Add an explicit
curl timeout so a stalled Discord endpoint cannot block the job indefinitely,
while preserving the existing HTTP status validation and error reporting.
In `@scripts/update-release-readiness.sh`:
- Around line 83-107: Update pin_issue and unpin_issue so non-idempotent GitHub
CLI failures are reported to stderr but do not return a failure status, allowing
the job to continue under set -e. Preserve the existing success handling and
already-pinned/not-pinned checks, and apply the same continuation behavior to
both helpers.
- Around line 71-81: Update write_output_multiline to generate a unique random
heredoc delimiter for each output instead of using the fixed AURRAL_EOF value,
and use that delimiter consistently for both the opening and closing markers.
Ensure pull_list and issue_list content cannot prematurely terminate the heredoc
or inject additional GitHub outputs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6be7005c-17c0-4d97-a5c6-b9d04c407e90
📒 Files selected for processing (6)
.github/workflows/nightly.yml.github/workflows/preview.yml.github/workflows/reconcile-release.yml.github/workflows/release.ymlscripts/notify-discord.shscripts/update-release-readiness.sh
- Include release notes, pull requests, and linked issues - Add change summaries to nightly and preview notifications
642ab8d to
39c6ec9
Compare
Aurral preview image readyThis image was rebuilt from the latest push to this pull request. It will be replaced when you push another change. docker pull ghcr.io/lklynet/aurral:pr-528To test it with your existing Docker Compose setup:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Included in stable release 2.1.0This change is included in the Aurral 2.1.0 release. docker pull ghcr.io/lklynet/aurral:2.1.0 |
Summary
Improve Discord notifications for releases, nightly builds, and preview images with release notes, pull requests, linked issues, and pull request summaries. Add GitHub API access and multiline workflow outputs to support richer notification content.
Linked issues
None
Validation
ghcr.io/lklynet/aurral:pr-<number>preview image, or not requiredTest plan
Release impact
Summary by CodeRabbit
New Features
Bug Fixes