Conversation
|
We are getting close to INT_MAX, how about making these |
The new format is much farther from it, do you still want ULL? |
I gave it a try - is that what you were thinking of? |
|
My personal opinion is that this should not be part of a patch release, so I would prefer to wait to merge this. Changing the format from 2026007000 to 20260701 would be very jarring and make using CAMP_VERSION even more complicated with having to handle special cases. |
|
Agreed. Forcing the change to a ULL seems reasonable, but I would note that even if it didn't have the qualifier on it increasing the version to a number requiring that size would have produced warnings for anyone assigning the literal to a smaller value. Honestly I'd prefer we keep the format and force the size change rather than change the format, it's less likely to cause downstream breakage that's undetectable by the compiler. |
CAMP_VERSION as defined in config.hpp.in would produce version numbers like 2026007000. Since the major and minor release numbers are now based on the year and month and patch releases are generally limited to one or two, a better format would be YYYYMMPP (e.g. 20260700). However, this would be an unexpected change for anyone relying on strictly increasing version numbers for Camp.
Resolves #216.
This is not a blocker for me, so no need to rush this in.