Skip to content

Update CAMP_VERSION format#218

Draft
adayton1 wants to merge 4 commits into
mainfrom
version
Draft

Update CAMP_VERSION format#218
adayton1 wants to merge 4 commits into
mainfrom
version

Conversation

@adayton1

@adayton1 adayton1 commented Jul 22, 2026

Copy link
Copy Markdown
Member

CAMP_VERSION as defined in config.hpp.in would produce version numbers like 2026007000. Since the major and minor release numbers are now based on the year and month and patch releases are generally limited to one or two, a better format would be YYYYMMPP (e.g. 20260700). However, this would be an unexpected change for anyone relying on strictly increasing version numbers for Camp.

Resolves #216.

This is not a blocker for me, so no need to rush this in.

@adayton1
adayton1 requested review from MrBurmark and rhornung67 July 22, 2026 19:19
rhornung67
rhornung67 previously approved these changes Jul 22, 2026
@MrBurmark

MrBurmark commented Jul 22, 2026

Copy link
Copy Markdown
Member

We are getting close to INT_MAX, how about making these ULL literals?

@adayton1

Copy link
Copy Markdown
Member Author

We are getting close to INT_MAX, how about making these ULL literals?

The new format is much farther from it, do you still want ULL?

@adayton1

Copy link
Copy Markdown
Member Author

We are getting close to INT_MAX, how about making these ULL literals?

The new format is much farther from it, do you still want ULL?

I gave it a try - is that what you were thinking of?

@adayton1

adayton1 commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

My personal opinion is that this should not be part of a patch release, so I would prefer to wait to merge this. Changing the format from 2026007000 to 20260701 would be very jarring and make using CAMP_VERSION even more complicated with having to handle special cases.

@adayton1
adayton1 marked this pull request as draft July 23, 2026 16:03
@trws

trws commented Jul 24, 2026

Copy link
Copy Markdown
Member

Agreed. Forcing the change to a ULL seems reasonable, but I would note that even if it didn't have the qualifier on it increasing the version to a number requiring that size would have produced warnings for anyone assigning the literal to a smaller value. Honestly I'd prefer we keep the format and force the size change rather than change the format, it's less likely to cause downstream breakage that's undetectable by the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version numbers

4 participants