fix(tests): gzip the trace data inside the stale dftracer fixtures#63
Merged
Merged
Conversation
dftracer-posix.tar.gz and dftracer-dlio-prev.tar.gz shipped uncompressed .pfw traces. The dftracer-utils indexer reads .pfw.gz, so both fixtures loaded as zero events -- the analyzer returned an empty analysis with exit 0, and the e2e assertions (view counts, layer counts) hold on an empty result, so CI stayed green while testing nothing. Repacked both so the traces inside are .pfw.gz. Contents are otherwise untouched; only the compression changed. preset=posix on dftracer-posix 0 -> 2,056 events preset=dlio-prev on dftracer-dlio-prev 0 -> 18,039 events
izzet
force-pushed
the
fix/gzip-stale-trace-fixtures
branch
from
July 26, 2026 01:07
b4d0299 to
16629d0
Compare
izzet
added
enhancement
izzet
added a commit
to izzet/dfanalyzer
that referenced
this pull request
Jul 26, 2026
The dftracer-utils indexer reads .pfw.gz. An uncompressed .pfw is globbed by resolve_trace_inputs but parses to nothing, so uploading one produced an empty analysis with no error -- the same silent-empty failure llnl#63 fixed in the test fixtures. Verified on the 8 traces from the dlio-prev fixture: as .pfw.gz they load 18,039 events / 8 processes; as plain .pfw the same data loads 0 events / 0 processes and the run still exits 0.
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dftracer-posix.tar.gzanddftracer-dlio-prev.tar.gzshipped uncompressed.pfwtraces. The dftracer-utils indexer reads.pfw.gz, so both fixtures loaded as zero events — the analyzer returned an empty analysis and exited 0.CI never noticed because the e2e assertions are structural (view counts, layer counts, checkpoint glob) and all hold true on an empty result. Two of the six matrix entries have been passing against no data.
Repacked both so the traces inside are
.pfw.gz. Contents are otherwise untouched — only the compression changed.posixondftracer-posixdlio-prevondftracer-dlio-prevVerification
pytest -m full— 165 passed, 22 deselected, in a clean non-editable venv.Note
This does not add an assertion that a non-zero event count was read, so the underlying detection gap remains open. Worth a follow-up.