Correctly strip multi-line ACK status lines - #211
Closed
alecbcs wants to merge 1 commit into
Closed
Conversation
alecbcs
force-pushed
the
fix/multi-line-ack-lines
branch
from
August 5, 2026 04:42
87c4a5f to
3413e5b
Compare
alecbcs
force-pushed
the
fix/multi-line-ack-lines
branch
from
August 5, 2026 04:43
3413e5b to
9c35fd0
Compare
alecbcs
force-pushed
the
fix/multi-line-ack-lines
branch
from
August 5, 2026 05:13
e92d38b to
274634e
Compare
Signed-off-by: Alec Scott <alec@llnl.gov>
alecbcs
force-pushed
the
fix/multi-line-ack-lines
branch
from
August 5, 2026 05:17
274634e to
68ff0ae
Compare
Member
Author
|
Going to close this and re-create and built on top of other smaller PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes "pack signature mismatch" error in fetch_pack → send_pack when the server response contains multiple NACK / ACK status lines. Previously we assumed (incorrectly) that there would only ever be a single status line before the returned packfile. In some complex mirror situations where multiple commits are reused across two remotes multiple status lines can be returned with a packfile.