Skip to content

ci: add security checks - #70

Merged
cmelone merged 2 commits into
llnl:mainfrom
cmelone:add/security-ci
Sep 4, 2025
Merged

ci: add security checks#70
cmelone merged 2 commits into
llnl:mainfrom
cmelone:add/security-ci

Conversation

@cmelone

@cmelone cmelone commented Sep 3, 2025

Copy link
Copy Markdown
Member

replica of llnl/hubcast#167 and llnl/hubcast#169:

  • adds Bandit (Python static security analysis) check to each PR
  • enables GitHub's CodeQL feature
  • adds permissions blocks to existing workflows

@cmelone
ci: add security checks
1bc4aae 
replica of llnl/hubcast#167 and
llnl/hubcast#169:

- adds Bandit (Python static security analysis) check to each PR
- enables GitHub's CodeQL feature
- adds permissions blocks to existing workflows
@github-actions github-actions Bot added ci Involving Project CI & Unit Tests dependencies Modifications to a Dependency File labels Sep 3, 2025
@github-advanced-security

github-advanced-security AI commented Sep 3, 2025

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cmelone

cmelone commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

@alecbcs thoughts on this alert? https://github.com/LLNL/repligit/security/code-scanning/6

we could ignore it if we decide it's not worth changing

https://stackoverflow.com/questions/68428293/s101-use-of-assert-detected-for-python-tests

@cmelone
cmelone requested a review from alecbcs September 4, 2025 00:07
alecbcs
alecbcs approved these changes Sep 4, 2025
View reviewed changes

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@cmelone
cmelone merged commit 92ebb48 into llnl:main Sep 4, 2025
12 checks passed
@cmelone
cmelone deleted the add/security-ci branch September 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecbcs alecbcs alecbcs approved these changes

Assignees

No one assigned

Labels

ci Involving Project CI & Unit Tests dependencies Modifications to a Dependency File

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmelone @github-advanced-security @alecbcs