fix(tracker): 区分外部建牌与 known 兜底#57
Merged
Merged
Conversation
显式记录 external-source 与 known-fallback 创建语义,避免 12 区正常建牌误入补确认诊断,同时保留缺失实体兜底日志。
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough本次变更为 Changes已知牌解析与确认
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
KnownCardCreationReason,显式区分external-source与known-fallback。createExternalCards为中性的实体/匿名占位创建入口,并在 known 解析层决定诊断语义。outside/exile、既有正 ID 暗实体和普通路径实体缺口补充注释、日志字段与回归测试。原因
额外区正常生成牌与 known 路径缺失实体都会调用
createExternalCards。此前仅根据新建实体的初始暗态补确认,导致 12 区正常建牌也被记录为兜底诊断,且无法从日志中明确辨别创建原因。验证
pnpm test:tracker(40 个测试文件,292 个测试通过)pnpm typecheck:trackerpnpm lintpnpm exec prettier --check src/tracker/roomMovement.ts src/tracker/roomMovement/types.ts src/tracker/Room.ts tests/tracker/knownDiscardConfirm.test.tspnpm buildpnpm build:prod风险与备注
createExternalCards的底层创建行为或匿名占位语义。Summary by CodeRabbit
Bug 修复
测试