[FIRRTL][HW] Factor HierPath builder util out of LowerXMR #8409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility for building `hw::HierPathOp`s at a specific location in the IR in a sane order and reusing ops when possible. This is added because this is a pattern that is used in `LowerXMR` and I'd like to reuse it in `LowerLayers`. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Changae the `LowerXMR` pass to use the new `HierPathBuilder` utility. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/hw-factor-out-hierpath-builder
branch
from
febc89c to
3057138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor a utility out of FIRRTL's
LowerXMRpass which is used forcreating
hw::HierPathOps. This does some useful things like caching andcreates the ops in order as opposed to in reverse order. Refactor
LowerXMRto use this utility.Context: I am planning to use this in
LowerLayersand this is theprerequisite work to make it a utility.