[SV] Add InnerRefUserOpInterface to sv.verbatim#9492
Merged
Conversation
This allows sv.verbatim to properly verify inner symbol references used in its symbols attribute. The implementation checks that all InnerRefAttr entries in the symbols array can be resolved in the inner reference namespace, ensuring the verbatim operation references valid inner symbols.
dtzSiFive
approved these changes
Jan 22, 2026
Contributor
dtzSiFive
left a comment
dtzSiFive
left a comment
There was a problem hiding this comment.
LGTM!
I think the other verbatim operations would benefit from this as well.
Do you mind having those implement the interface as well (sv.verbatim.expr, sv.verbatim.expr.se)?
I believe they can share the verification logic.
Can tackle in a follow-up to, this is good as-is.
Thanks!
Contributor
|
Thanks, @uenoku ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows sv.verbatim to properly verify inner symbol references used in its symbols attribute. The implementation checks that all InnerRefAttr entries in the symbols array can be resolved in the inner reference namespace, ensuring the verbatim operation references valid inner symbols.
Ref: #9491