[FIRRTL][CAPI] Update RefType creation to support layers#9600
Merged
[FIRRTL][CAPI] Update RefType creation to support layers#9600
Conversation
Contributor
|
Thanks for taking a look at this! I think it would be better to add a new function for getting "layer-coloured ref types", and the original getter can continue to return uncoloured ref types. How does that sound? |
Member
Author
That makes complete sense, actually I had considered that but not decided. I've made the change, thanks for the suggestion! |
Expose `firrtlTypeGetColoredRef` to allow creating `RefType` with an associated layer attribute via the C API. This enables creating reference types that are constrained to specific layers, mirroring the functionality available in the C++ API. Signed-off-by: unlsycn <unlsycn@unlsycn.com>
rwy7
approved these changes
Feb 3, 2026
Arya-Golkari
pushed a commit
to Arya-Golkari/circt
that referenced
this pull request
Feb 7, 2026
Expose `firrtlTypeGetColoredRef` to allow creating `RefType` with an associated layer attribute via the C API. This enables creating reference types that are constrained to specific layers, mirroring the functionality available in the C++ API. Signed-off-by: unlsycn <unlsycn@unlsycn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
firrtlTypeGetRefto accept alayerattribute. This takes over #8093.