[circt-reduce] Add list-create-element-remover reduction#9603
Merged
[circt-reduce] Add list-create-element-remover reduction#9603
Conversation
Add a new reduction pattern that removes individual elements from FIRRTL list.create operations. This generates one match per element in each list, allowing selective removal of elements during test case reduction. Lists can be any size afterwards, including zero-size. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> AI-assisted-by: Augment (Claude Sonnet 4.5)
seldridge
added
FIRRTL
Member
Author
|
Note: this could likely be better handled with changing the constantifier to introduce |
fabianschuiki
approved these changes
Feb 4, 2026
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! This is going to be a very handy reduction. I've run into this pattern of long lists quite a bit in the past. 🥇
seldridge
deleted the
dev/seldridge/firrtl-circt-reduce-list-create-reducer
branch
Arya-Golkari
pushed a commit
to Arya-Golkari/circt
that referenced
this pull request
Feb 7, 2026
Add a new reduction pattern that removes individual elements from FIRRTL list.create operations. This generates one match per element in each list, allowing selective removal of elements during test case reduction. Lists can be any size afterwards, including zero-size. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> AI-assisted-by: Augment (Claude Sonnet 4.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new reduction pattern that removes individual elements from
FIRRTL list.create operations. This generates one match per element
in each list, allowing selective removal of elements during test case
reduction.
Lists can be any size afterwards, including zero-size.
AI-assisted-by: Augment (Claude Sonnet 4.5)