Merged
Conversation
Fails to compile in strict headers mode because SmallSet/SymbolRefAttr are not defined. No functional change.
Member
|
Looks fine and I'm generally in favor of including what you use. Could you clarify what settings you used to compile this to flag this as an error? |
Contributor
Author
|
In Google the build system is set up to use -fheader-modules or some variant of modules, so the header is compiled in isolation and doesn't get to see the prior includes in any .cpp that includes it. |
Member
|
Nice. Thanks for the explanation and the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fails to compile in strict headers mode because SmallSet/SymbolRefAttr
are not defined.
No functional change.