[FIRRTL] Dedup: fix non-deduplicatable public module handling#9702
Merged
[FIRRTL] Dedup: fix non-deduplicatable public module handling#9702
Conversation
When we decide to skip deduplicating a module, we must record its name as being mapped to itself in the dedup map. This was, incorrectly, not done for modules which were skipped due to being public, and this change fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two equivalent public modules cannot be deduplicated into each other, the pass was failing to record the module in the deduplication map. When a parent module looks up such a module when renaming its children, it would see a null attribute, and think that child was equal to any other unmapped child, which could cause parent modules to dedup when their children did not. This change fixes the issue by making sure we record the self-mapping of non-deduplicatable modules before continuing to the next module.