[KB] Use --dtype instead of --bf16 - #176
Merged
Merged
Conversation
As noted in the TODO, this PR makes use of llvm#169 to allow conversion of models to an appropriate data type. For now, only F32 and BF16 are supported, but it should not be hard to make other data types available. Also, fix the bf16 output return and add tests in CI.
tkarna
approved these changes
Jun 2, 2026
I cannot reproduce the error on the same machine.
adam-smnk
reviewed
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in the TODO, this PR makes use of #169 to allow conversion of models to an appropriate data type. For now, only F32 and BF16 are supported, but it should not be hard to make other data types available.
Also, fix the bf16 output return and add tests in CI.