Skip to content

[ingress][torch] Use Runner in PyTorch backend - #178

Merged
adam-smnk merged 1 commit into
llvm:mainfrom
adam-smnk:torch-use-runner
Jun 3, 2026
Merged

[ingress][torch] Use Runner in PyTorch backend#178
adam-smnk merged 1 commit into
llvm:mainfrom
adam-smnk:torch-use-runner

Conversation

@adam-smnk

Copy link
Copy Markdown
Member

Refactors PyTorch MLIR backend to lighthouse's Runner for consistent execution path.

Assisted-by: Claude

Refactors PyTorch MLIR backend to lighthouse's Runner for consistent
execution path.

Assisted-by: Claude
@adam-smnk
adam-smnk requested review from rengolin and tkarna June 2, 2026 15:30

@tkarna tkarna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was thinking we could remove the memory manager if we migrate to use system shared memory for GPU but this PR indicates that having some functionality may be useful in general. Anyway, we can revisit later.

@adam-smnk

Copy link
Copy Markdown
Member Author

I was thinking we could remove the memory manager if we migrate to use system shared memory for GPU

That's an option, for now I follow the existing pattern.

but this PR indicates that having some functionality may be useful in general.

Perhaps, the accepted interface could also be largely simplified.
Alternatively, Runner APIs could accept packed args or wider range of possible types.
TBD in the future, indeed.

@adam-smnk
adam-smnk merged commit 03118d9 into llvm:main Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants