[utils] Enable OS AMX support - #207
Conversation
Adds utility function that enables AMX registers in OS. Explicit AMX register config is required before AMX instructions can be executed.
| ) | ||
| Parser.add_argument( | ||
| "--target", | ||
| type=str, |
There was a problem hiding this comment.
should we include choices here to indicate which targets are supported?
There was a problem hiding this comment.
I think it'd make sense but here I'm just forwarding flags as is.
There was a problem hiding this comment.
this is an open list, we can't list all possible targets, as you can make up something new and connect the dots separately.
There was a problem hiding this comment.
In practice, we only support a few according to available pipelines.
Anyway, let's leave that to a separate PR.
There was a problem hiding this comment.
It's mostly a service to the user as one can use --help to see what the options are. Otherwise one would have to see where the target is being used an try to reverse-engineer the possible values. But yeah, it increases maintenance burden as we'd need to update the list every time we add support for a new target.
There was a problem hiding this comment.
the help string has some examples,we don't have a full list
|
we should merge this before #209 so that we only do this once |
3 participants
Adds utility function that enables AMX registers in OS.
Explicit AMX register config is required before AMX instructions can be executed.