[openmp][cmake] Don't glob for build dependencies #165231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
openmp:libomp
Meinersbur
changed the title
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
LLVM's cmake standard explicitly lists all source in the CMakeLists.txt. Remove globbing for source files in OpenMP's CMakeLists.txt. Also see llvm#4899, llvm#71404, https://reviews.llvm.org/D79906, https://reviews.llvm.org/D31363, https://reviews.llvm.org/D61275, https://discourse.llvm.org/t/cmake-builds-clang/11536, and CMake's note at https://cmake.org/cmake/help/latest/command/file.html#glob. Two reasons to not glob for source files is that it breaks bisecting and incremental builds. Renaming a file, reverting or checking out an older reversion where a newly added source file disappears again will not trigger a CMake configure step and make the build fail because of a non-existing source file.
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
LLVM's cmake standard explicitly lists all source in the CMakeLists.txt. Remove globbing for source files in OpenMP's CMakeLists.txt. Also see llvm#4899, llvm#71404, https://reviews.llvm.org/D79906, https://reviews.llvm.org/D31363, https://reviews.llvm.org/D61275, https://discourse.llvm.org/t/cmake-builds-clang/11536, and CMake's note at https://cmake.org/cmake/help/latest/command/file.html#glob. Two reasons to not glob for source files is that it breaks bisecting and incremental builds. Renaming a file, reverting or checking out an older reversion where a newly added source file disappears again will not trigger a CMake configure step and make the build fail because of a non-existing source file.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
LLVM's cmake standard explicitly lists all source in the CMakeLists.txt. Remove globbing for source files in OpenMP's CMakeLists.txt. Also see llvm#4899, llvm#71404, https://reviews.llvm.org/D79906, https://reviews.llvm.org/D31363, https://reviews.llvm.org/D61275, https://discourse.llvm.org/t/cmake-builds-clang/11536, and CMake's note at https://cmake.org/cmake/help/latest/command/file.html#glob. Two reasons to not glob for source files is that it breaks bisecting and incremental builds. Renaming a file, reverting or checking out an older reversion where a newly added source file disappears again will not trigger a CMake configure step and make the build fail because of a non-existing source file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM's cmake standard explicitly lists all source in the CMakeLists.txt. Remove globbing for source files in OpenMP's CMakeLists.txt.
Also see #4899, #71404, https://reviews.llvm.org/D79906, https://reviews.llvm.org/D31363, https://reviews.llvm.org/D61275, https://discourse.llvm.org/t/cmake-builds-clang/11536, and CMake's note at https://cmake.org/cmake/help/latest/command/file.html#glob. Two reasons to not glob for source files is that it breaks bisecting and incremental builds. Renaming a file, reverting or checking out an older reversion where a newly added source file disappears again will not trigger a CMake configure step and make the build fail because of a non-existing source file.