Skip to content

Conversation

@mtrofin
Copy link
Member

@mtrofin mtrofin commented Dec 9, 2025

The test introduced in #171118 has llc inadvertently producing an output into the same dir as the test file itself. Most build bots don't clean up the local git repo, which is assumed to not be written by build + test, and patch on top (for build performance reasons), which means the produced output from the aforementioned PR is treated as a test from here onwards, by all bots. Since it's missing RUN lines, we get errors, for example  https://lab.llvm.org/buildbot/#/builders/108/builds/20674

This patch fixes the llc line and also removes the .s. This avoids all bot maintainers go restart their bots. Then, the cleanup is removed in #171256.

Copy link
Member Author

mtrofin commented Dec 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mtrofin mtrofin marked this pull request as ready for review December 9, 2025 04:54
@mtrofin mtrofin requested a review from kyulee-com December 9, 2025 04:55
@mtrofin mtrofin merged commit ce76c39 into main Dec 9, 2025
4 of 5 checks passed
@mtrofin mtrofin deleted the users/mtrofin/12-08-fix_test_outputting_to_test_dir branch December 9, 2025 04:56
@nocchijiang
Copy link
Contributor

Sorry for breaking the builds, and thanks for the fix. I thought piping to FileCheck wasn't necessary since the test doesn't use CHECK lines. It appears FileCheck handles the temporary file deletion.

Copy link
Member Author

mtrofin commented Dec 9, 2025

Sorry for breaking the builds, and thanks for the fix. I thought piping to FileCheck wasn't necessary since the test doesn't use CHECK lines. It appears FileCheck handles the temporary file deletion.

No worries, it happens!

btw, it's not FileCheck. Rather, if you:

llc < %s -> this will produce the output to stdout (...and this would have also been a fix)
llc %s -> this, by default, will produce an output next to the input (...and probably you meant to do the above but missed the <)

honeygoyal pushed a commit to honeygoyal/llvm-project that referenced this pull request Dec 9, 2025
The test introduced in llvm#171118 has `llc` inadvertently producing an
output into the same dir as the test file itself. Most build bots don't
clean up the local git repo, which is assumed to not be written by build
+ test, and patch on top (for build performance reasons), which means
the produced output from the aforementioned PR is treated as a test from
here onwards, by all bots. Since it's missing `RUN` lines, we get
errors, for example
 https://lab.llvm.org/buildbot/#/builders/108/builds/20674

This patch fixes the `llc` line and also removes the `.s`. This avoids
all bot maintainers go restart their bots. Then, the cleanup is removed
in llvm#171256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants