Remove cleanup of incorrect output in test dir #171256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
|
@llvm/pr-subscribers-backend-aarch64 Author: Mircea Trofin (mtrofin) ChangesFull diff: https://github.com/llvm/llvm-project/pull/171256.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AArch64/arm64-homogeneous-prolog-epilog-tail-call.mir b/llvm/test/CodeGen/AArch64/arm64-homogeneous-prolog-epilog-tail-call.mir
index ec094109cad6e..3c6c365de87f0 100644
--- a/llvm/test/CodeGen/AArch64/arm64-homogeneous-prolog-epilog-tail-call.mir
+++ b/llvm/test/CodeGen/AArch64/arm64-homogeneous-prolog-epilog-tail-call.mir
@@ -1,4 +1,3 @@
-# RUN: rm -rf %S/arm64-homogeneous-prolog-epilog-tail-call.s
# RUN: llc -verify-machineinstrs -mtriple=arm64-applie-ios7.0 -start-before=aarch64-lower-homogeneous-prolog-epilog -homogeneous-prolog-epilog %s -o /dev/null
#
# This test ensures defined registers are preserved after lowering homogeneous
|
mtrofin
added a commit
that referenced
this pull request
Dec 9, 2025
The test introduced in #171118 has `llc` inadvertently producing an output into the same dir as the test file itself. Most build bots don't clean up the local git repo, which is assumed to not be written by build + test, and patch on top (for build performance reasons), which means the produced output from the aforementioned PR is treated as a test from here onwards, by all bots. Since it's missing `RUN` lines, we get errors, for example https://lab.llvm.org/buildbot/#/builders/108/builds/20674 This patch fixes the `llc` line and also removes the `.s`. This avoids all bot maintainers go restart their bots. Then, the cleanup is removed in #171256.
Base automatically changed from
users/mtrofin/12-08-fix_test_outputting_to_test_dir
to
main
December 9, 2025 04:56
mtrofin
force-pushed
the
users/mtrofin/12-08-remove_cleanup_of_incorrect_output_in_test_dir
branch
from
0944643 to
82a1a33
Compare
boomanaiden154
approved these changes
Dec 9, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM. Probably want to wait 12 hours or so for the bots to cycle.
Thanks for fixing this.
Member
Author
|
I'll land this a bit later to make sure all bots (including those that take batches of changes) run #171255 first. |
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
The test introduced in llvm#171118 has `llc` inadvertently producing an output into the same dir as the test file itself. Most build bots don't clean up the local git repo, which is assumed to not be written by build + test, and patch on top (for build performance reasons), which means the produced output from the aforementioned PR is treated as a test from here onwards, by all bots. Since it's missing `RUN` lines, we get errors, for example https://lab.llvm.org/buildbot/#/builders/108/builds/20674 This patch fixes the `llc` line and also removes the `.s`. This avoids all bot maintainers go restart their bots. Then, the cleanup is removed in llvm#171256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #171255 , removing the cleanup line.