Skip to content

[AMDGPU][NFC] Add an optional DSE pass during CodeGenPrepare #172069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmc-rep wants to merge 1 commit into from
Closed

[AMDGPU][NFC] Add an optional DSE pass during CodeGenPrepare #172069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
#include "llvm/Transforms/IPO/GlobalDCE.h"
#include "llvm/Transforms/IPO/Internalize.h"
#include "llvm/Transforms/Scalar.h"
#include "llvm/Transforms/Scalar/DeadStoreElimination.h"
#include "llvm/Transforms/Scalar/EarlyCSE.h"
#include "llvm/Transforms/Scalar/FlattenCFG.h"
#include "llvm/Transforms/Scalar/GVN.h"
Expand Down Expand Up @@ -355,6 +356,12 @@ static cl::opt<bool> EnableLoadStoreVectorizer(
cl::init(true),
cl::Hidden);

// Option to enable DSE in backend.
static cl::opt<bool>
EnableDeadStoreElimination("amdgpu-dead-store-elimination",
cl::desc("Enable dead store elimination"),
cl::init(false), cl::Hidden);

// Option to control global loads scalarization
static cl::opt<bool> ScalarizeGlobal(
"amdgpu-scalarize-global-loads",
Expand Down Expand Up @@ -1413,6 +1420,10 @@ void AMDGPUPassConfig::addCodeGenPrepare() {
addPass(createAMDGPULowerKernelArgumentsPass());

TargetPassConfig::addCodeGenPrepare();
// TODO: Remove DSE when LoadStoreVectorizer is enhanced to handle
// partially overlapping vector-stores.
if (isPassEnabled(EnableDeadStoreElimination))
addPass(createDeadStoreEliminationPass());

if (isPassEnabled(EnableLoadStoreVectorizer))
addPass(createLoadStoreVectorizerPass());
Expand Down Expand Up @@ -2183,6 +2194,10 @@ void AMDGPUCodeGenPassBuilder::addCodeGenPrepare(AddIRPass &addPass) const {
addPass(AMDGPULowerKernelArgumentsPass(TM));

Base::addCodeGenPrepare(addPass);
// TODO: Remove DSE when LoadStoreVectorizer is enhanced to handle
// partially overlapping vector-stores.
if (isPassEnabled(EnableDeadStoreElimination))
addPass(DSEPass());

if (isPassEnabled(EnableLoadStoreVectorizer))
addPass(LoadStoreVectorizerPass());
Expand Down