[llvm][DebugInfo] Use formatv in LVDWARFReader

[kwk]

This relates to #35980.

Here are all independent PRs that deal with replacing format with formatv in llvm/lib/DebugInfo:

• -> [llvm][DebugInfo] Use formatv in LVDWARFReader #192011
• [llvm][DebugInfo] formatv in LVCodeViewVisitor #192010
• [llvm][DebugInfo] formatv in LVBinaryReader #192009
• [llvm][DebugInfo] formatv in LVScope #192008
• [llvm][DebugInfo] Use formatv in LVReader #192007
• [llvm][DebugInfo] formatv in LVRange #192006
• [llvm][DebugInfo] formatv in LVObject #192004
• [llvm][DebugInfo] formatv in LVLocation #192003
• [llvm][DebugInfo] formatv in LVElement #192002
• [llvm][DebugInfo] Use formatv in LVCompare #192001
• [llvm][DebugInfo] Use formatv in GsymReaderV1 and GsymReaderV2 #192000
• [llvm][DebugInfo] formatv in DWARFUnwindTablePrinter #191999
• [llvm][DebugInfo] Use formatv in DWARFUnitIndex #191998
• [llvm][DebugInfo] formatv in DWARFTypeUnit #191997
• [llvm][DebugInfo] formatv in DWARFListTable #191996
• [llvm][DebugInfo] Use formatv in DWARFGdbIndex #191994
• [llvm][DebugInfo] Use formatv in DWARFExpressionPrinter #191993
• [llvm][DebugInfo] formatv in DWARFDie #191992
• [llvm][DebugInfo] formatv in DWARFDebugRnglists #191991
• [llvm][DebugInfo] formatv in DWARFDebugRangeList #191989
• [llvm][DebugInfo] Use formatv in DWARFDebugPubTable #191988
• [llvm][DebugInfo] formatv in DWARFDebugMacro #191987
• [llvm][DebugInfo] formatv in DWARFDebugLine #191986
• [llvm][DebugInfo] formatv in DWARFDebugFrame #191984
• [llvm][DebugInfo] formatv in DWARFContext #191983
• [llvm][DebugInfo] Use formatv in DWARFCFIPrinter #191982
• [llvm][DebugInfo] Use formatv in DWARFAcceleratorTable #191981
• [llvm][DebugInfo] Add more format/formatv equivalence tests #191980

[llvmbot]

@llvm/pr-subscribers-debuginfo

Author: Konrad Kleine (kwk)

Changes

This relates to #35980.

---

Full diff: https://github.com/llvm/llvm-project/pull/192011.diff

1 Files Affected:

• (modified) llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp (+3-3)

diff --git a/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
index 772d821dcda81..ca642ef421f60 100644
--- a/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
@@ -210,7 +210,7 @@ void LVDWARFReader::processOneAttribute(const DWARFDie &Die,
           FoundLowPC = false;
           // We are dealing with an index into the .debug_addr section.
           LLVM_DEBUG({
-            dbgs() << format("indexed (%8.8x) address = ", (uint32_t)UValue);
+            dbgs() << formatv("indexed ({0:x-8}) address = ", (uint32_t)UValue);
           });
         }
       }
@@ -263,8 +263,8 @@ void LVDWARFReader::processOneAttribute(const DWARFDie &Die,
       if (!RangesOrError) {
         LLVM_DEBUG({
           std::string TheError(toString(RangesOrError.takeError()));
-          dbgs() << format("error decoding address ranges = ",
-                           TheError.c_str());
+          dbgs() << formatv("error decoding address ranges = {0}",
+                            TheError.c_str());
         });
         consumeError(RangesOrError.takeError());
         break;

[s-barannikov]

This could use fmt_consume(RangesOrError.takeError())

[kwk]

Addressed in 3e27479

[DavidSpickett]

LGTM assuming you clean up the TheError part.

[github-actions]

🐧 Linux x64 Test Results

• 193736 tests passed
• 5060 tests skipped

✅ The build succeeded and all tests passed.

[github-actions]

🪟 Windows x64 Test Results

• 133644 tests passed
• 3113 tests skipped

✅ The build succeeded and all tests passed.