[libc] Add byteswap.h to Linux public header target lists#200345
Merged
Conversation
The headers don't get installed without this. Assisted by Gemini.
|
@llvm/pr-subscribers-backend-risc-v Author: Pavel Labath (labath) ChangesThe headers don't get built/installed without this. Full diff: https://github.com/llvm/llvm-project/pull/200345.diff 3 Files Affected:
diff --git a/libc/config/linux/aarch64/headers.txt b/libc/config/linux/aarch64/headers.txt
index e321c5425f662..0e136586cf35b 100644
--- a/libc/config/linux/aarch64/headers.txt
+++ b/libc/config/linux/aarch64/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
diff --git a/libc/config/linux/riscv/headers.txt b/libc/config/linux/riscv/headers.txt
index d7ae420240280..4b3766d74de2e 100644
--- a/libc/config/linux/riscv/headers.txt
+++ b/libc/config/linux/riscv/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
diff --git a/libc/config/linux/x86_64/headers.txt b/libc/config/linux/x86_64/headers.txt
index 1aa63784e8aab..2ea83e963bd58 100644
--- a/libc/config/linux/x86_64/headers.txt
+++ b/libc/config/linux/x86_64/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
|
|
@llvm/pr-subscribers-libc Author: Pavel Labath (labath) ChangesThe headers don't get built/installed without this. Full diff: https://github.com/llvm/llvm-project/pull/200345.diff 3 Files Affected:
diff --git a/libc/config/linux/aarch64/headers.txt b/libc/config/linux/aarch64/headers.txt
index e321c5425f662..0e136586cf35b 100644
--- a/libc/config/linux/aarch64/headers.txt
+++ b/libc/config/linux/aarch64/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
diff --git a/libc/config/linux/riscv/headers.txt b/libc/config/linux/riscv/headers.txt
index d7ae420240280..4b3766d74de2e 100644
--- a/libc/config/linux/riscv/headers.txt
+++ b/libc/config/linux/riscv/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
diff --git a/libc/config/linux/x86_64/headers.txt b/libc/config/linux/x86_64/headers.txt
index 1aa63784e8aab..2ea83e963bd58 100644
--- a/libc/config/linux/x86_64/headers.txt
+++ b/libc/config/linux/x86_64/headers.txt
@@ -1,6 +1,7 @@
set(TARGET_PUBLIC_HEADERS
libc.include.arpa_inet
libc.include.assert
+ libc.include.byteswap
libc.include.complex
libc.include.cpio
libc.include.ctype
|
Contributor
Author
|
I'm sorry, I did not realize that automerge will not wait for a review before submitting this. I think the patch is pretty straightforward, but do let me know if you see any issues with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headers don't get built/installed without this.