eTss desugar recursively #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[lldb] Modify call to ASTContext::get as per new signature
…tions with the same name." This reverts commit 9454716. The patch being reverted results in swift-corelibs-foundation failing to build due to being unable to find `Glibc.pthread_mutex_t`. The declaration is defined in the module, but is also imported via CDispatch. This patch marks any complete redeclarations of a given declaration incomplete. Swift can't import incomplete declarations, so it is ignored in `ClangImporter::isVisibleFromModule`. We will need some mechanism of detecting redeclarations while not marking complete declarations as being incomplete.
Cherry-pick llvm#3316 [lldb] Modify call to ASTContext::get as per new signature
…resent This change fixes a bug where the compiler generates a prologue_end for line 0 locs. That is because line 0 is not associated with any source location, so there should not be a prolgoue_end at a location that doesn't correspond to a source location. There were some LLVM tests that were explicitly checking for line 0 prologue_end's as well since I believe that to be incorrect, I had to change those tests as well. Patch by Shubham Rastogi! Differential Revision: https://reviews.llvm.org/D110740 (cherry picked from commit 9f93f2b)
This has the nice side-effect that it can actually store the quadruple version numbers that Apple's tools are using nowadays. rdar://82982162 Differential Revision: https://reviews.llvm.org/D111200 (cherry picked from commit 14aa3f3) Conflicts: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
(cherry picked from commit 2edb905)
(cherry picked from commit 8c5f334)
This patch adds support for Swift compiler producer strings to DWARFUnit. Differential Revision: https://reviews.llvm.org/D111278 (cherry picked from commit aab7afeec1fb771c8ae044257d44f6362d72c732)
…g-type [lldb] Make DemangleCanonicalType use GetCanonicalType
Get CFString.test to pass
Update test after health log patch
…g-pthread_mutex_t Revert "[modules] Fix miscompilation when using two RecordDecl definitions with the same name."
…tion" This reverts commits f9aba9a and 035217f. As explained in the original commit message, this didn't have the intended effect of improving the common LLDB use case, but still provided a marginal improvement for the places where LLDB creates a scoped time with a string literal. The reason for the revert is that this change pulls in the os/signpost.h header in Signposts.h. The former transitively includes loader.h, which contains a series of macro defines that conflict with MachO.h. There are ways to work around that, but Adrian and I concluded that none of them are worth the trade-off in complicating Signposts.h even further. (cherry picked from commit 070315d)
In -P mode, PrintPPOutputPPCallbacks::MoveToLine started at least one newline if current and target line number mismatched. The method is also called when entering a new file, be it the main file or an include file. In this situation line numbers always almost mismatch, resulting in a newline for each occurance even if no tokens have been printed in-between. Empty lines at the beginning of the output must be trimmed because it may be parsed by scripts expecting the result to appear on the first output line, as done by LibreOffice's configure script. Fix by only emitting a newline if tokens have been printed so far using the EmittedTokensOnThisLine flag. Also adding a test case of FileChanged callbacks occuring with empty include files. This fixes llvm.org/PR51616 (cherry picked from commit 66e37c9)
Work around outdated system header files on Amazon Linux
…1fa8d7f32426ffdc7b69aca73c2 [Preprocessor] Elide empty line(s) at start of file.
…15a851124a7c7f6e6 Revert "Allow signposts to take advantage of deferred string substitution"
This patch changes the `ScriptedThread` initializer in couple of ways: - It replaces the `SBTarget` parameter by a `SBProcess` (pointing to the `ScriptedProcess` that "owns" the `ScriptedThread`). - It adds a reference to the `ScriptedProcessInfo` Dictionary, to pass arbitrary user-input to the `ScriptedThread`. This patch also fixes the SWIG bindings methods that call the `ScriptedProcess` and `ScriptedThread` initializers by passing all the arguments to the appropriate `PythonCallable` object. Differential Revision: https://reviews.llvm.org/D112046 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This is failing on Arm and AArch64 Linux buildbots since the time it was comitted. https://lab.llvm.org/buildbot/#/builders/96/builds/12628 Differential Revision: https://reviews.llvm.org/D107585
This patch changes the ScriptedProcess test to use a stack-only skinny corefile as a backing store. The corefile is saved as a temporary file at the beginning of the test, and a second target is created for the ScriptedProcess. To do so, we use the SBAPI from the ScriptedProcess' python script to interact with the corefile process. This patch also makes some small adjustments to the other ScriptedProcess scripts to resolve some inconsistencies and removes the raw memory dump that was previously checked in. Differential Revision: https://reviews.llvm.org/D112047 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
…(NFC) Because TestScriptedProcess.py creates a skinny corefile to provides data to the ScriptedProcess and ScriptedThread, we need to make sure that the debugserver used is not out of tree, to ensure feature availability between debugserver and lldb. This also removes the `SKIP_SCRIPTED_PROCESS_LAUNCH` env variable after each test finish running. Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This patch changes the ScriptedThread class to create the register context when Process::RefreshStateAfterStop is called rather than doing it in the thread constructor. This is required to update the thread state for execution control. Differential Revision: https://reviews.llvm.org/D112167 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This patch replaces `DynamicRegisterInfo.h` include path since the file has been moved upstream in 214054f, but merging that change requires cherry-picking multiple patches that could potentially affect the branch stability. Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
[lldb] Add support for ScriptedProcess
…9d77133201e1f404a8023c [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT
…functions We might emit functions that are private and never called. The coro split pass only processes functions that might be called. Remove intrinsics that we can't generate code for. rdar://84619859
…d00b5b429d77133201e1f404a8023c Revert "[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT"
Merge definition visibility the same way we do for other decls. Without the fix the added test emits `-Wobjc-method-access` as it cannot find a visible protocol. Make this warning `-Werror` so the test would fail when protocol visibility regresses. rdar://83600696 Differential Revision: https://reviews.llvm.org/D111860 (cherry picked from commit 7ad693a)
…s_in_private Coro: Remove coro_end and coro_suspend_retcon in private unprocessed functions
This change does what it says on the tin: it allows SwiftAttr to be used with #pragma clang attribute push to add Swift attributes to large regions of header files. We plan to use this to annotate headers with concurrency information. Reviewed at https://reviews.llvm.org/D112773. Fixes rdar://83499885.
[20210726] Allow __attribute__((swift_attr)) in attribute push pragmas
It turns out that the --leading-lines may be a bad default. [[#@line+-num]] is rarely used.
Improve error handling for the lang objc tagged-pointer info. Rather than failing silently, report an error if we couldn't convert an argument to an address or resolve the class descriptor. (lldb) lang objc tagged-pointer info 0xbb6404c47a587764 error: could not get class descriptor for 0xbb6404c47a587764 (lldb) lang objc tagged-pointer info n1 error: could not convert 'n1' to a valid address Differential revision: https://reviews.llvm.org/D112945 (cherry picked from commit 50b40b0)
- Use formatv to print the addresses. - Add check for 0x0 which is treated as an invalid address. - Use a an address that's less likely to be interpreted as a real tagged pointer. (cherry picked from commit f9e6be5)
Don't try to get a class descriptor for a pointer that doesn't look like a tagged pointer. Also print addresses as fixed-width hex and update the test. (cherry picked from commit 10eb32f)
Somehow every pointer looks like it's tagged on GreenDragon. Removing the check to unblock the bot until we can get to the bottom of this. (cherry picked from commit d09a21a)
The 14.31.30818 toolset has the following in the `stdatomic.h`: ~~~ #ifndef __cplusplus #error <stdatomic.h> is not yet supported when compiling as C, but this is planned for a future release. #endif ~~~ This results in clang failing to build existing code which relied on `stdatomic.h` in C mode on Windows. Simply fallback to the clang header until that header is available as a complete implementation. (cherry picked from commit 1ad7de9)
Headers: exclude `#include_next <stdatomic.h>` on MSVC
[lldb] Use reflection metadata to find the value type of an existential
…a2+10eb32f45d40+d09a21a0b378 🍒/FBI/50b40b051890+f9e6be5cc1a2+10eb32f45d40+d09a21a0b378
[20210726][split-file] Default to --no-leading-lines
|
This repository does not accept pull requests. Please follow http://llvm.org/docs/Contributing.html#how-to-submit-a-patch for contribution to LLVM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
30 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.