Add CLI resume and crawl rate limit options#3105
Merged
Merged
Conversation
Add CLI resume and crawl rate limit options
dipu-bd
approved these changes
Jul 13, 2026
dipu-bd
left a comment
dipu-bd
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good. Thanks for taking up this task. I will wait for further clarification on the resume option before merging it
| metavar="N", | ||
| help="Download latest few chapters", | ||
| ), | ||
| resume: bool = typer.Option( |
Collaborator
There was a problem hiding this comment.
Why add an explicit resume since the default behavior of the crawl command is to resume the download?
Collaborator
There was a problem hiding this comment.
ah I understand, you are not even fetching the list of chapters that is marked with is_crawled True
Contributor
Author
There was a problem hiding this comment.
Exactly. That keeps the progress bar and queued task count focused on only missing chapters, which is especially useful for large novels or interrupted downloads. The default behavior remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add CLI resume and crawl rate limit options
Type of change
Details
Add --resume / --missing to the CLI crawl command to download only chapters that are not marked as downloaded.
Add --refresh to force re-downloading selected chapters.
Add --rate-limit to override the crawler task rate for a single CLI crawl run.
The crawler services already skip available chapters and the scheduler already supports fetching missing chapters, but the non-interactive CLI did not expose that behavior clearly. This makes interrupted downloads easier to continue and gives users a per-run throttle without editing crawler source code.
Checklist
make lintpasses with no errors