feat(flash): wire Discord webhook env vars (ops feed + alerts)#240
Merged
Conversation
…ents (chart 3.2.42) Adds OPS_DISCORD_WEBHOOK_URL and ALERT_DISCORD_WEBHOOK_URL to the api, ibex-webhook, and bridge-webhook deployments via secretKeyRef against a new 'discord-webhooks' secret (keys: ops-webhook-url, alert-webhook-url), optional: true so environments without the secret still schedule pods. Follows the *ExistingSecret convention; galoy-secrets.yaml renders the secret for secrets.create=true installs, omitting keys whose values are empty (an empty-string env var would fail the backend's zod .url() validation and crash pods at boot — caught by the dev smoketest). Backend consumer: lnflash/flash#458 (ops activity feed + alerts module). Real deployments provision the secret out-of-band (secrets.create=false). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXnQYUbKQe5wUCWEvdAau7
islandbitcoin
force-pushed
the
flash-ops-webhook-env
branch
from
July 23, 2026 01:40
31ec341 to
fb7d413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires two secret-backed env vars into the flash chart, chart
3.2.40 → 3.2.41:OPS_DISCORD_WEBHOOK_URL— new ops activity feed (feat: Discord ops activity feed for key user flows flash#458)ALERT_DISCORD_WEBHOOK_URL— existing alerts module, previously not wired in any templateBoth are injected into the three workloads that emit events:
api-deployment(graphql-main-server),ibex-webhook-deployment, andbridge-webhook-deployment, viasecretKeyRef→ secretdiscord-webhooks(keysops-webhook-url/alert-webhook-url), following the*ExistingSecretpattern (galoy.discordWebhooksExistingSecretin values).optional: trueso environments without the secret keep working — the backend no-ops when the vars are unset.helm lintclean; rendered output verified to include the vars in all three deployments. (Note:secrets.create=truerendering is broken at HEAD from a pre-existing nil.Values.postgresql.enabled— unrelated; defaultcreate=falserenders clean.)Operator step (out-of-band, per cluster)
TEST first, then prod. Rollout after merge is the usual chart publish → deployments pin bump →
make flash ENV=<env>.🤖 Generated with Claude Code
https://claude.ai/code/session_01UXnQYUbKQe5wUCWEvdAau7