smite-ir: add LookupShortChannelId operation - #155
Merged
Conversation
devvaansh
force-pushed
the
lookup-short-channel-id
branch
2 times, most recently
from
July 17, 2026 16:46
5082f5e to
779e50b
Compare
morehouse
reviewed
Jul 24, 2026
morehouse
left a comment
morehouse
left a comment
Collaborator
There was a problem hiding this comment.
Just missing an executor test.
Comment on lines
923
to
+935
| pub fn has_side_effects(&self) -> bool { | ||
| match self { | ||
| Self::SendMessage | ||
| | Self::SendOpenChannel | ||
| | Self::SendFundingCreated | ||
| | Self::SendChannelReady { .. } | ||
| | Self::RecvAcceptChannel | ||
| | Self::RecvFundingSigned | ||
| | Self::RecvChannelReady | ||
| | Self::MineBlocks(_) | ||
| | Self::CreateFundingTransaction | ||
| | Self::BroadcastTransaction => true, | ||
| | Self::BroadcastTransaction | ||
| | Self::LookupShortChannelId => true, |
Collaborator
There was a problem hiding this comment.
I would argue that LookupShortChannelId does not have side effects, since it is a read-only operation. But I see that we need it here to prevent CSE from merging it with other lookups, since the result is nondeterministic (depends on the relative position of a MineBlocks operation).
I think it's fine to put it here to keep this PR simple. But this inconsistency hints that we may want a separate is_deterministic function for use by CSE, which could be a follow-up PR.
Contributor
Author
There was a problem hiding this comment.
Agreed. It's purely a read- no I/O, no state mutation. The only reason it's in has_side_effects is to keep CSE from collapsing two lookups that straddle a MineBlocks. Will track is_deterministic as a follow-up.
devvaansh
force-pushed
the
lookup-short-channel-id
branch
from
July 24, 2026 18:06
779e50b to
86782fe
Compare
morehouse
reviewed
Jul 24, 2026
devvaansh
force-pushed
the
lookup-short-channel-id
branch
from
July 24, 2026 19:28
86782fe to
c397439
Compare
morehouse
approved these changes
Jul 27, 2026
devvaansh
force-pushed
the
lookup-short-channel-id
branch
2 times, most recently
from
July 27, 2026 17:16
a2bb508 to
4fac511
Compare
Adds an IR operation that takes a broadcast FundingTransaction and produces the BOLT 7 short_channel_id derived from its confirmed block position. This bridges the on-chain funding output to the gossip layer so channel_announcement, channel_update, and announcement_signatures messages can reference a real UTXO and pass on-chain validation in CLN and LND. Under the hood the executor calls BitcoinCli::get_transaction_block_position and combines the returned (block_height, tx_index) with the funding transaction's vout. If the transaction is unknown to the node or still in the mempool (e.g. a mutator dropped MineBlocks between the broadcast and the lookup), the sentinel ShortChannelId::new(0, 0, 0) is produced instead of panicking: the resulting gossip message simply fails on-chain validation, which is the desired behaviour for a valid but unconfirmed program. The BitcoinRpc trait grows a get_transaction_block_position method with a MockBitcoinCli implementation that mirrors the existing confirmations mock.
devvaansh
force-pushed
the
lookup-short-channel-id
branch
from
July 27, 2026 17:17
4fac511 to
f76879f
Compare
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
LookupShortChannelId, which takes aFundingTransactionand produces the BOLT 7short_channel_idderived from its confirmed block position.This is the missing piece needed to build validly-signed gossip messages that reference a real on-chain UTXO and can pass the UTXO validation checks in CLN and LND.
If the transaction is not yet confirmed (e.g. a mutator dropped
MineBlocks), the sentinelShortChannelId::new(0, 0, 0)is returned rather than panicking. A valid but unconfirmed program should not be a fatal error.Ref: #71