Add BBA measurement script to scripts repo#181
Merged
fernandohds564 merged 30 commits intomasterfrom Sep 23, 2025
Merged
Conversation
- now incorporating support for continuing failed/stopped previous measurments - support for list of BPMs names, txt file with BPMs names and regexp with BPMs names patterns for selecting `bpms2dobba`
vellosok75
requested review from
VitorSouzaLNLS,
anacso17,
fernandohds564 and
xresende
- more explicit workflow - added some TODOs comments - handles some exceptions exitnig execution
xresende
reviewed
Jul 22, 2025
Contributor
xresende
left a comment
xresende
left a comment
There was a problem hiding this comment.
typo "filenamein" in function helper
Contributor
Some spaces and line breaks were missing. After commit "FIX: Line breaks" it should now be fixed. |
- bpms2dobba: now accepts space-separated list of BPMs names or regexp patterns, filename or "all" - print-setup arg: to print the required setup prior to running - print-bpms arg: to print the indices and names of BPMs (can be handy during operations), without launching the measurement
- added documentation -get_bpms_for_bba`: dedicated function to handle BPM selection from either user's input or previous progress
- preserves the ordering from the previous measurement. - works if bpms2dobba from previous meas was arbitrarily ordered
- `bba_configure` func content moved to `main` - funcs appearing in `main` show first, funcs used by them come later - reordering of script args - new script args: -r, --run-meas; -t, --timeout; --sofb_maxcorriter
- intercept ctrl+C & kill to guarantee meas.stop() is called prior to exiting
- if fname included file extension, logic was broken
- new measurement now continues from previous one - new data is added to the same file from previours progress - changed arg `--ignore-previous` to `resume-meas` - new arg overrides any other arg and uses same params from previous meas - minor aesthetic changes
- if fname is not speciefied, use default value based on date
- use all bpms if bpms2dobba not given - minor changes in help
- replace `print-all-bpms` flag by `print-bpms-quads` to include also the quads associated to the BPMs
- now using single-quotes
- relevant keyword (bpm, bba, loco) first
- back to single quotes - ruff pattern for imports
fernandohds564
requested changes
Sep 18, 2025
fernandohds564
approved these changes
Sep 18, 2025
- accept master's state, with the use of `use6dtrack` flag
xresende
approved these changes
Sep 23, 2025
if --resume-meas was not passed and fname coincided with an existing file, data from this file would be overwritten Now, an error is raised, educating the user
…o add-meas-scripts
anacso17
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script to launch BBA measurements. Includes:
bpms2dobbaThese new functionalities depend on having the list
bpms2dobbasaved in the BBA data file. This change is implemented in lnls-fac/apsuite#301See the helper
This PR also includes changes in other measurement scripts (loco fitting & setting strengths, BPM acquisitions)
sirius-script-siprefix, now comes the experiment keyword eg:sirius-script-si-loco-run-fitting.py,sirius-script-si-loco-set-strengths.py. This facilitates auto-completion.The different changes are separated by commits so it's easy to review them individually.