chore: remove Golden Honey Badger schema, locales, and asset (PR2/2)#792
Merged
grunch merged 1 commit intoissue790-pr1-disable-ghbfrom Apr 28, 2026
Merged
chore: remove Golden Honey Badger schema, locales, and asset (PR2/2)#792grunch merged 1 commit intoissue790-pr1-disable-ghbfrom
grunch merged 1 commit intoissue790-pr1-disable-ghbfrom
Conversation
Final cleanup. Existing documents in MongoDB that still hold is_golden_honey_badger will simply have the field ignored — no migration script needed since Mongoose stops casting the field once it's removed from the schema. - models/order: drop is_golden_honey_badger from IOrder and schema - ordersActions / takeOrder: drop is_golden_honey_badger writes - locales: drop golden_honey_badger key from all 10 languages - images: delete Honeybadger.png Closes #790 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
grunch
added a commit
that referenced
this pull request
Apr 28, 2026
* chore: disable Golden Honey Badger feature (PR1/2) Stop assigning the Golden Honey Badger image and zero-fee bypass to new orders, drop the user-facing congratulatory messages, and remove the type definitions and signatures the feature relied on. Existing orders in the database keep working since their fee was already calculated at creation time. - imageCache: remove probability check, honeybadger cache slot, honeybadgerCached stat, and isGoldenHoneyBadger from generateRandomImage return - getFee: drop isGoldenHoneyBadger parameter and conditional logic - ordersActions: hard-code is_golden_honey_badger to false and drop isGoldenHoneyBadger from BuildDescriptionArguments - takeOrder: hard-code is_golden_honey_badger to false; drop the unnecessary await on synchronous generateRandomImage - messages: drop congratulatory blocks and isGoldenHoneyBadger param from showHoldInvoiceMessage - showHoldInvoice: always charge full fee - .env-sample: drop GOLDEN_HONEY_BADGER_PROBABILITY Refs #790 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: remove Golden Honey Badger schema, locales, and asset (PR2/2) (#792) Final cleanup. Existing documents in MongoDB that still hold is_golden_honey_badger will simply have the field ignored — no migration script needed since Mongoose stops casting the field once it's removed from the schema. - models/order: drop is_golden_honey_badger from IOrder and schema - ordersActions / takeOrder: drop is_golden_honey_badger writes - locales: drop golden_honey_badger key from all 10 languages - images: delete Honeybadger.png Closes #790 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_golden_honey_badgerfromIOrderinterface and Mongoose schema.golden_honey_badgeri18n key from all 10 locale files.images/Honeybadger.png.is_golden_honey_badgerwrites left over after PR1.Stacked on top of #791 — review/merge that one first. Existing documents in MongoDB that still hold
is_golden_honey_badgerwill simply have the field ignored once Mongoose stops casting it; no migration script needed.Closes #790
Test plan
npx tsccleannpm test120 passingnpm run lintcleanis_golden_honey_badger/golden_honey_badger/Honeybadgerreferences remain (grep -rn ...)🤖 Generated with Claude Code