Skip to content

ci: run workflows on main pushes - #320

Merged
loadinglucian merged 5 commits into
mainfrom
feat/ci-main-push-triggers
Feb 8, 2026
Merged

ci: run workflows on main pushes#320
loadinglucian merged 5 commits into
mainfrom
feat/ci-main-push-triggers

Conversation

@loadinglucian

@loadinglucian loadinglucian commented Feb 8, 2026

Copy link
Copy Markdown
Owner

Adds workflow triggers to run CI on pushes to main branch.

@coderabbitai

coderabbitai Bot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adds push triggers for branches: [main] to multiple GitHub Actions workflows, deletes the claude.yml workflow, removes the wait_for_dns_a_record() helper from BATS test helpers, and deletes related DNS A-record wait calls in cloud BATS tests; a couple jobs have increased timeouts.

Changes

Cohort / File(s) Summary
Cloud workflow (bats)
​.github/workflows/bats-cloud.yml
Adds push trigger for branches: [main], extends cloud-tests job condition to run on pushes or non-fork PR heads, increases timeout-minutes 10→12.
VM workflow
​.github/workflows/bats-vm.yml
Adds push trigger for branches: [main]; increases timeout-minutes 10→12 for vm-tests.
Other CI workflows
​.github/workflows/ci-canary.yml, ​.github/workflows/pest.yml, ​.github/workflows/phpstan.yml, ​.github/workflows/pint.yml, ​.github/workflows/rector.yml
Each workflow now also triggers on push to branches: [main]; no other behavior changes.
Removed workflow
​.github/workflows/claude.yml
Deleted entire workflow file.
BATS tests — cloud providers
tests/bats/cloud-aws.bats, tests/bats/cloud-do.bats
Removed DNS A-record wait calls and related server IP retrievals from teardowns and several test paths (DNS checks, HTTPS deployment, HTTP verification).
BATS helpers
tests/bats/lib/cloud-helpers.bash
Removed the wait_for_dns_a_record() helper function (DNS query, IP-matching, timeout handling and messages removed).
Docs
CONTRIBUTING
Added a note referencing a dotagents repository for equivalent agent SKILLs (content-only).

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding workflow triggers to run CI on pushes to the main branch, which aligns with all modified workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description accurately describes the primary changes: adding workflow triggers to run CI on pushes to the main branch, which aligns with modifications across multiple workflow files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Lucian Behind The Scenes and others added 4 commits February 8, 2026 15:30
Remove wait_for_dns_a_record calls and function definition from cloud
test suites. DNS validation is now handled by site:dns:check command
directly, eliminating redundant waiting logic.

Co-authored-by: Cursor <cursoragent@cursor.com>
Increase timeout for bats-cloud and bats-vm workflows from 10 to 12 minutes
to accommodate longer test runs. Remove unused claude.yml workflow.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@CONTRIBUTING`:
- Line 17: Revise the awkward phrase "I have a
[dotagents](https://github.com/loadinglucian/dotagents) with equivalent agent
SKILLs" to clarify that it's a repository—e.g., change to "I maintain a
[dotagents](https://github.com/loadinglucian/dotagents) repository containing
equivalent agent SKILLs" or "See the [dotagents] repository for equivalent agent
SKILLs" so the intent is explicit; update the CONTRIBUTING line accordingly.

Comment thread CONTRIBUTING Outdated
@loadinglucian
loadinglucian merged commit 815f9a7 into main Feb 8, 2026
10 checks passed
@loadinglucian
loadinglucian deleted the feat/ci-main-push-triggers branch February 8, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant