馃摑 Add docstrings to refactor/process-service-replacement - #39
Merged
loadinglucian merged 1 commit intoOct 11, 2025
Merged
Conversation
Docstrings generation was requested by @lucianvacaroiu. * https://github.com/bigpixelrocket/deployer-php/pull/38#issuecomment-3393662882 The following files were modified: * `app/Contracts/BaseCommand.php` * `app/DTOs/SiteDTO.php` * `app/Repositories/SiteRepository.php` * `app/Services/ProcessService.php` * `app/Services/VersionService.php` * `tests/Fixtures/TestConsoleCommand.php` * `tests/TestHelpers.php`
Contributor
Author
|
Important Review skippedCodeRabbit bot authored PR detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
loadinglucian
merged commit Oct 11, 2025
c8aface
into
refactor/process-service-replacement
4 of 5 checks passed
loadinglucian
added a commit
that referenced
this pull request
Oct 11, 2025
* refactor(process): replace ProcessFactory with ProcessService Replace the ProcessFactory class with ProcessService to provide a more standardized service layer implementation with dependency injection support and better testability. The new service encapsulates process execution logic while maintaining the same interface compatibility. * feat(site): add SiteDTO and SiteRepository Introduce SiteDTO for site configuration data and SiteRepository for inventory management. This establishes foundational components for site-related functionality, following the same pattern as server management. * refactor(command): update BaseCommand and testing helpers Update BaseCommand with improved console output and input methods. Adjust test fixtures and helpers to maintain compatibility and enhance test isolation for command testing. * refactor(process): remove ProcessFactory and its test Remove the deprecated ProcessFactory class and corresponding test file following successful replacement with ProcessService. * fix(version): minor updates to VersionService Apply small fixes and improvements to the VersionService implementation for better reliability and consistency with service layer patterns. * refactor: make ProcessService timeout parameter non-nullable - Changed timeout parameter from ?float to float in ProcessService::run() - Removed null coalescing operator since parameter cannot be null - Fixed test to omit parameter instead of passing null when testing default behavior - All existing usages already rely on default value without passing null * 馃摑 Add docstrings to `refactor/process-service-replacement` (#39) Docstrings generation was requested by @lucianvacaroiu. * https://github.com/bigpixelrocket/deployer-php/pull/38#issuecomment-3393662882 The following files were modified: * `app/Contracts/BaseCommand.php` * `app/DTOs/SiteDTO.php` * `app/Repositories/SiteRepository.php` * `app/Services/ProcessService.php` * `app/Services/VersionService.php` * `tests/Fixtures/TestConsoleCommand.php` * `tests/TestHelpers.php` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @lucianvacaroiu.
The following files were modified:
app/Contracts/BaseCommand.phpapp/DTOs/SiteDTO.phpapp/Repositories/SiteRepository.phpapp/Services/ProcessService.phpapp/Services/VersionService.phptests/Fixtures/TestConsoleCommand.phptests/TestHelpers.phpThese files were ignored
tests/Unit/Contracts/BaseCommandTest.phptests/Unit/DTOs/SiteDTOTest.phptests/Unit/Repositories/SiteRepositoryTest.phptests/Unit/Services/ProcessServiceTest.php鈩癸笍 Note