fix: set group-writable permissions on shared storage during deploy - #35
Merged
Merged
Conversation
Add set_group_writable_tree helper to keep shared storage paths writable for both the deploy user and PHP-FPM (www-data). Applies SGID + 2775 on directories and 664 on files so new entries inherit the group. Also cleans up YAML sequence formatting in inventory.yml.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRestructures deployment inventory YAML configuration into nested list format for servers and sites. Adds a permission helper function to the deployment script and applies group-writable permissions to shared storage directories and database paths. Replaces cache clearing mechanism with an artisan command. Changes
Possibly related PRs
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
set_group_writable_treehelper to the deploy script that applies SGID (2775) on directories and664on files, ensuring the shared storage tree stays writable for both the deploy user and PHP-FPM (www-data). The helper is called after shared directories are created and again after Artisan commands run (which can create new cache/session/log paths).Also applies the same permissions to the shared SQLite database path, and fixes YAML sequence formatting in
inventory.yml.