Skip to content

fix: remove owner filter from chmod in shared storage normalization - #37

Merged
loadinglucian merged 1 commit into
mainfrom
fix/chmod-all-files-in-shared-storage
Feb 25, 2026
Merged

fix: remove owner filter from chmod in shared storage normalization#37
loadinglucian merged 1 commit into
mainfrom
fix/chmod-all-files-in-shared-storage

Conversation

@loadinglucian

Copy link
Copy Markdown
Owner

Removes the -user "${current_user}" filter from find commands in set_group_writable_tree, so chmod applies to all files and directories regardless of owner.

Previously, only deployer-owned files were normalized. Files owned by www-data or other users were silently skipped. The 2>/dev/null || true safety net handles any permission errors gracefully.

@loadinglucian
loadinglucian merged commit 2745012 into main Feb 25, 2026
@loadinglucian
loadinglucian deleted the fix/chmod-all-files-in-shared-storage branch February 25, 2026 16:45
@coderabbitai

coderabbitai Bot commented Feb 25, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d57204 and 57703ed.

📒 Files selected for processing (1)
  • .deployer/scripts/deploy.sh

📝 Walkthrough

Walkthrough

The set_group_writable_tree function in the deploy script was modified to apply chmod operations to all directories and files within a given path, removing the previous filter that limited changes to items owned by the current user.

Changes

Cohort / File(s) Summary
Deploy script permissions handling
.deployer/scripts/deploy.sh
Modified set_group_writable_tree function to apply chmod to all directories and files regardless of ownership. Removed current user detection logic and the -user "${current_user}" filter constraint. The change expands the scope of permission modifications from user-owned items only to all items in the target path.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant