FD-672: Upgrade Node.js from v20 to v24#534
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version from 20 to 24 across the project, including the .node-version file, the contract tests Dockerfile, and the package configuration files. The reviewer recommends pinning the Docker base image to the exact Node.js version (24.15.0-alpine) instead of using a floating tag to ensure build consistency and reproducibility.
Insecure Access Control (1)
More info on how to fix Insecure Access Control in Dockerfile. Vulnerable Libraries (18)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
- Bump .node-version to 24.15.0 - Update package.json engines to >=24.0.0 - Update Dockerfile to node:24-alpine (floating tag for OS patches) - Add actions/setup-node@v4 step to ci.yml and cd.yml - Fix deprecated set-output command in cd.yml to use GITHUB_OUTPUT
a97d311 to
926c467
Compare
NateWaldschmidt
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-node@v4toci.ymlandcd.yml(these were missing it;deploy.ymlalready had it)Dockerfiletonode:24-alpine(floating tag so OS security patches apply automatically)package.jsonengines to>=24.0.0set-outputcommand incd.yml→ uses$GITHUB_OUTPUT