fix: use python -m build in make publish, drop setup.py#61
Merged
Conversation
PyPI now rejects sdist filenames from the legacy `setup.py sdist` path (hyphenated) since it enforces PEP 625 normalized names (underscore). Switch to `python -m build`, which also produces a wheel. setup.py was just a `setup()` shim; replaced with a minimal pyproject.toml declaring the setuptools build backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make publishused./setup.py sdist, which produces a hyphenated sdist filename (localstack-client-X.Y.tar.gz); PyPI now enforces PEP 625 normalized filenames (underscore) and rejects the upload with a 400.python -m build --sdist --wheel, which produces correctly named artifacts and also builds a wheel (previously only an sdist was published).setup.py(was just asetup()shim) and added a minimalpyproject.tomldeclaring the setuptools build backend, sincepython -m buildneeds one or the other present.setup.cfgstill holds all package metadata, untouched.Discovered this while publishing v2.12 — upload failed with:
Test plan
python -m build --sdist --wheelproduceslocalstack_client-2.12.tar.gz+.whlwith correct normalized namestwine check dist/*passesmake lintpassesmake testpasses (10/10, same as before this change)