Fix error message for missing snapshot - #23
Merged
Conversation
alexrashed
approved these changes
Aug 31, 2026
alexrashed
left a comment
alexrashed
left a comment
Member
There was a problem hiding this comment.
Totally makes sense, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a key is marked as snapshotted, but not actually present in the
snapshot.json, the following error is thrown:This is very confusing though, as there is a state for
tests/mytest.pypresent - it is just missing the state for a specific key.This PR updates the error message to make it clear that only the
keyis missing, instead of the entire snapshot.