This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Revert hypercorn binding to privileged ports#9012
Merged
Merged
Conversation
This reverts commit 8246af9.
simonrw
added
the
semver: patch
alexrashed
approved these changes
Aug 29, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on this! 🚀
It's a pity we have to revert this, but we'll come back to it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When binding hypercorn on privileged ports, if one of the ports is not available the entire hypercorn server will fail to bind, leaving LocalStack in a terminal failure state. This state is not caught in a user friendly way (the background thread dies leaving a traceback).
Changes