This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Let hypercorn listen directly to privileged ports if run as root#9232
Merged
Conversation
…roper check for unprivileged port range start
simonrw
reviewed
Sep 26, 2023
simonrw
approved these changes
Sep 26, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is basically a continuation of #8948 and #9012.
We basically reintroduce hypercorn binding directly to the privileged ports, if run as root.
Additionally, we check the
sys.net.ipv4.ip_unprivileged_port_startkernel parameter, to check the port start of unprivileged ports.We will need to provide proper paths of error handling, to avoid #9012 again.
Changes