Show license plan in header for self-validating emulators - #283
Merged
Conversation
Member
Author
|
Possibly related to #265. @anisaoshafi what do you think, is this useful? |
gtsiolis
force-pushed
the
show-plan-label-self-validating-emulators
branch
5 times, most recently
from
July 7, 2026 07:09
fb60939 to
c2ce0d2
Compare
gtsiolis
force-pushed
the
show-plan-label-self-validating-emulators
branch
3 times, most recently
from
July 13, 2026 07:08
577daab to
4a195f7
Compare
gtsiolis
force-pushed
the
show-plan-label-self-validating-emulators
branch
4 times, most recently
from
July 22, 2026 07:07
bd12b0f to
a63f484
Compare
gtsiolis
force-pushed
the
show-plan-label-self-validating-emulators
branch
2 times, most recently
from
July 28, 2026 07:11
c828f1e to
6ce5009
Compare
Azure and Snowflake starts left the header plan label blank: lstk deliberately skips the license API for self-validating emulators (no catalog entry for their products), and run.go conflated "no resolved version" with "already running", sending the (empty) cached label. Resolve the label from the license the container activates into its volume (cache/license.json) instead — no extra license API activation — falling back to "LocalStack" when the file is unavailable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
gtsiolis
force-pushed
the
show-plan-label-self-validating-emulators
branch
from
August 4, 2026 10:43
6ce5009 to
5b605af
Compare
gtsiolis
marked this pull request as ready for review
August 4, 2026 10:58
anisaoshafi
approved these changes
Aug 4, 2026
anisaoshafi
left a comment
anisaoshafi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this UX bug on self-validating emulators 💯
Member
Author
|
Thanks for merging, @anisaoshafi! 🏀 Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Starting the Azure or Snowflake emulator could leave the TUI header's plan label blank or show a stale cached label from another emulator.
These emulators validate their own licenses, so lstk deliberately skips its platform license flow and does not resolve an image version for them. The UI treated an empty resolved version only as "the emulator was already running" and reused the cached label, which is also empty on a fresh install.
Changes
<volume>/cache/license.jsonand render labels such asLocalStack Enterprise.LocalStackwhen the activated license is unavailable or malformed, so the header is never blank.Validation
make test(1,434 tests)make test-integration RUN=TestStartCommandForAzureShowsPlanFromActivatedLicensego vet ./internal/container ./internal/uiReview: Human review is advisable to confirm that the activated license path and
license_typeformat are stable contracts for both Azure and Snowflake images.Co-Authored-By: Claude noreply@anthropic.com