Stream lstk logs lines to real terminal scrollback - #418
Merged
anisaoshafi merged 1 commit intoJul 30, 2026
Merged
Conversation
anisaoshafi
force-pushed
the
devx-1027-interactive-lstk-logs-does-not-preserve-scrollback
branch
from
July 29, 2026 17:02
f18fe34 to
4d0c7c1
Compare
anisaoshafi
force-pushed
the
devx-1027-interactive-lstk-logs-does-not-preserve-scrollback
branch
from
July 29, 2026 17:36
4d0c7c1 to
e92edc1
Compare
anisaoshafi
marked this pull request as ready for review
July 29, 2026 17:43
skyrpex
approved these changes
Jul 30, 2026
skyrpex
left a comment
Contributor
There was a problem hiding this comment.
Thanks, now the lstk logs command is really useful 👍🏻
anisaoshafi
deleted the
devx-1027-interactive-lstk-logs-does-not-preserve-scrollback
branch
July 30, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lstk logscapped history at 200 lines and repainted it in place, so terminal scrollback stopped growing past that point (unlikedocker logs/--non-interactive).LogLineEventnow prints permanently above the TUI via a newoutput.NewStreamingLogSink+Program.Println, bypassing the capped buffer.tea.Cmd) to keep lines in order — Bubble Tea runs returnedCmds concurrently, which reordered lines in an earlier pass.Test plan
lstk logsunder a real PTY, all survive in ordermake test+make lintclean--non-interactiveunchangedCloses DEVX-1027