Use generated id in the returned url, if in use - #59
Merged
Conversation
Contributor
|
The fix here is to actually return the url that corresponds to the id assigned to the client (in the case where they requested an id which was not available?) |
Contributor
Author
|
Yeah, that what this PR does...
It returns the randomly generated id, if the id requested is in use...
Den 18. mar. 2017 5.23 PM skrev "Roman Shtylman" <notifications@github.com>:
… The fix here is to actually return the url that corresponds to the id
assigned to the client (in the case where they requested an id which was
not available?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJI5BZdFOfqF7f6Zl5dQRjfiY93WS6mks5rnHV_gaJpZM4Mhj8F>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like
new_clientmay overwrite thereq_idwith a generated value, if theidalready is in use by another client.This causes an inconsistency between id and url. This is just a quick fix to make it consistent.
I suspect a proper fix would be some sort of
secret_tokenreturned the client that reserves theid. So that other clients can't use it. But that might be overkill, keeping the service simple seems like a good choice :)