Skip to content

Use generated id in the returned url, if in use - #59

Merged
defunctzombie merged 1 commit into
localtunnel:masterfrom
jonasfj:patch-1
Dec 10, 2017
Merged

Use generated id in the returned url, if in use#59
defunctzombie merged 1 commit into
localtunnel:masterfrom
jonasfj:patch-1

Conversation

@jonasfj

@jonasfj jonasfj commented Mar 18, 2017

Copy link
Copy Markdown
Contributor

Seems like new_client may overwrite the req_id with a generated value, if the id already is in use by another client.

This causes an inconsistency between id and url. This is just a quick fix to make it consistent.

I suspect a proper fix would be some sort of secret_token returned the client that reserves the id. So that other clients can't use it. But that might be overkill, keeping the service simple seems like a good choice :)

@defunctzombie

Copy link
Copy Markdown
Contributor

The fix here is to actually return the url that corresponds to the id assigned to the client (in the case where they requested an id which was not available?)

@jonasfj

jonasfj commented Mar 19, 2017 via email

Copy link
Copy Markdown
Contributor Author

@defunctzombie
defunctzombie merged commit 2539755 into localtunnel:master Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants