Skip to content

Conversation

@metasim
Copy link
Member

@metasim metasim commented Aug 19, 2019

No description provided.

@metasim metasim requested a review from vpipkt August 19, 2019 14:42
vpipkt added 2 commits August 20, 2019 15:13
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Copy link
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lingering things from PR #284 that i think i did not get in until after merge.

In some of the rendered HTML docs the resulting tables were really wide, not responsive, and no scroll bar. I am not sure if this is an issue any more.

here was a specific trouble spot: #284 (comment)

One problem for me now is I am getting errors building the docs: org.pegdown.ParsingTimeoutException there is some really long un-truncated line that is being output someplace. Looks like time series markdown is 5MB...

* develop: (21 commits)
  Add ignored test from stale branch
  Expressions returning primitives can't return `null`, so changing how constant tiles are created to keep catalyst optimizer from pruning them.
  mm
  m
  Added tests for rf_convert_cell_type and rf_with_no_data. Fixed a bug with counting data/no_data cells on constant tiles.
  a
  Time series doc reorg vector filtering
  time series park geojson filepath variabl
  Additional fixes for issue locationtech#242 that cropped back up.
  ci tweak to get error markdown
  Attempt to save markdown artifacts on failed docs build.
  Attempt to save markdown artifacts on failed docs build.
  Tweak partitions
  Add folium to setup / requirements
  DataFrame API only, folium display of temp file
  Reenabled test (mostly) covered by 242.
  Fix for columnar functions which accept `Tile` or `ProjectedRasterTile`, but claimed all return values were `Tile`. This was problematic whenever the `Tile` as reified, and the serialization of `ProjectedRasterTile` confused the `Tile` deserializer.
  Bump python development version to match JVM version
  Updated copyright in template.
  Update LICENSE
  ...
…ipython-display-tweaks

* commit '1ea29f2ccdc74eb3e900fbb075eae6e9421ea11a':
  Bug was with changes to `rf_with_no_data` acceptance of either `Double` or `Int`, and then incorrectly changing floating point tiles into a float cell type. Fixes locationtech#304.
  Updated ShowableTile to render NoData values differently.
  Moved array function tests to RasterFunctionsSpec.

# Conflicts:
#	pyrasterframes/src/main/python/pyrasterframes/rf_ipython.py
@metasim metasim merged commit 0506fb1 into locationtech:develop Aug 22, 2019
@metasim metasim deleted the feature/ipython-display-tweaks branch August 22, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants