Skip to content

Conversation

@metasim
Copy link
Member

@metasim metasim commented Aug 14, 2019

No description provided.

@metasim metasim requested a review from vpipkt August 14, 2019 01:27
@metasim
Copy link
Member Author

metasim commented Aug 14, 2019

Another "I don't know why this build is failing" issue:

https://travis-ci.org/locationtech/rasterframes/builds/571611437#L4212-L4215

Copy link
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not yet been able to look at all of it. But one breaking change in setup.py needs fix.

Copy link
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few styling questions here and there to consider. Have you tested in jupyter notebook environment?

@vpipkt vpipkt mentioned this pull request Aug 15, 2019
…t test

Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt
Copy link
Member

vpipkt commented Aug 15, 2019

☝️ trying to fix the build / unit tests

Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt
Copy link
Member

vpipkt commented Aug 15, 2019

OK that oughta do it

@metasim metasim merged commit 18ed679 into locationtech:develop Aug 15, 2019
@metasim metasim deleted the feature/df_to_markdown branch August 15, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants